[PATCH 09/15] dwarf_onesrcline.c: Add locking
Aaron Merey
amerey@redhat.com
Fri Jan 24 02:19:57 GMT 2025
Hi Mark,
On Wed, Jan 22, 2025 at 7:15 PM Mark Wielaard <mark@klomp.org> wrote:
>
> On Sun, Jan 19, 2025 at 10:20:35PM -0500, Aaron Merey wrote:
> > * libdw/dwarf_onesrcline.c (dwarf_onesrcline): Use dwarf_lock.
>
> Is this really necessary? When the user calls dwarf_onesrcline
> wouldn't they already have a fully setup Dwarf_Lines? Can it still
> change concurrently?
Hmm as with dwarf_lineaddr, I had previously seen helgrind flag
dwarf_onesrcline during testing but I am unable to reproduce an
error with these locks commented out. I'm not sure why this is.
I'll drop this patch until I can prove there is a need for it.
Aaron
More information about the Elfutils-devel
mailing list