[PATCH 01/15] Add eu_search_tree_init

[Aaron Merey]

Hi Mark,

On Wed, Jan 22, 2025 at 10:23 AM Mark Wielaard <mark@klomp.org> wrote:
> On Sun, 2025-01-19 at 22:20 -0500, Aaron Merey wrote:
> >       * libdw/dwarf_begin_elf.c (dwarf_begin_elf): Initialize
> >       eu_search_trees.
>
> I see the same are already eu_search_tree_fini in dwarf_end. So my only
> question is how this worked before?

I commented out these inits and re-ran the testsuite with thread safety
and valgrind enabled (I did a run with memcheck and a run with
helgrind).  All tests passed, including the thread safety ones.

I'm not sure what's going on but I have seen at least one test failure
due to these missing inits.  Possibly rwlock and tsearch/tfind
have a chance to work on certain uninitialized values, e.g. if they
happen to be 0?

Aaron