[PATCH 07/15] dwarf_lineaddr.c: Add locking
Mark Wielaard
mark@klomp.org
Thu Jan 23 00:08:27 GMT 2025
Hi Aaron,
On Sun, Jan 19, 2025 at 10:20:33PM -0500, Aaron Merey wrote:
> * libdw/dwarf_lineaddr.c (dwarf_lineaddr): Use dwarf_lock.
Why is this necessary? It seems this function can only be called with a known/setup Dwarf_Line. Can it be concurrently changes at this point?
> Signed-off-by: Aaron Merey <amerey@redhat.com>
>
> ---
> libdw/dwarf_lineaddr.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/libdw/dwarf_lineaddr.c b/libdw/dwarf_lineaddr.c
> index 4e1952d3..bf81966c 100644
> --- a/libdw/dwarf_lineaddr.c
> +++ b/libdw/dwarf_lineaddr.c
> @@ -40,7 +40,9 @@ dwarf_lineaddr (Dwarf_Line *line, Dwarf_Addr *addrp)
> if (line == NULL)
> return -1;
>
> + mutex_lock (line->files->dbg->dwarf_lock);
> *addrp = line->addr;
> + mutex_unlock (line->files->dbg->dwarf_lock);
>
> return 0;
> }
> --
> 2.47.1
>
More information about the Elfutils-devel
mailing list