[Bug libelf/32311] elf_compress_gnu.c: gcc warns null-dereference with lto

[mark at klomp dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=32311

Mark Wielaard <mark at klomp dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mark at klomp dot org

--- Comment #1 from Mark Wielaard <mark at klomp dot org> ---
Odd this wasn't seen before. There have been various lto enabled builds in
other distros.

The compiler seems to assume elf(32|64)_getshdr can fail and return NULL.
Which it theoretically could. But if that was true we wouldn't have reached
this code because there is another elf(32|64)_getshdr earlier in the function
that does do a NULL check and returns early.

We could maybe rewrite the function a bit to reuse the result of this earlier
function calls(s).

-- 
You are receiving this mail because:
You are on the CC list for the bug.