[PATCH 6/6] Use file stream or format variants of stdio print functions
Mark Wielaard
mark@klomp.org
Tue Oct 15 20:40:03 GMT 2024
Hi Michael,
On Tue, Oct 15, 2024 at 03:10:16PM +0000, Michael Pratt wrote:
> > If we are trying to be more consistent then I think I would prefer we
> > use putchar, puts, and printf, instead of adding stdout to all these
> > calls.
>
> I don't really have a preference, you could even throw out this last patch.
> I just thought it would be nice to remove use of one of the functions
> from the whole project to reduce needless variations and save the need to link
> more functions that do the exact same thing and waste binary space.
>
> Also, that searching "puts" results in "outputs" and "inputs"...
>
> It would be nice to have patch 5 before release,
> for patch 6 doesn't matter if or when to me.
>
> Let me know if you want a v2 of either patch 5 or 6.
Lets postpone the consistency/renaming patch to after the release. If
you could simplify patch 5 by just changing the putprint_unlocked
functions to their putprint variant that would be appreciated.
Thanks,
Mark
More information about the Elfutils-devel
mailing list