[patch] test tempdir move

[Mark Wielaard]

Hi Frank,

On Wed, Oct 09, 2024 at 04:43:56PM -0400, Frank Ch. Eigler wrote:
> > I like the idea of this change. Some nitpicks below.
> 
> Those were great ideas, v2 below:
> 
> From 65efbafc16fffa582a84c277493d2531bf88021a Mon Sep 17 00:00:00 2001
> From: "Frank Ch. Eigler" <fche@redhat.com>
> Date: Wed, 9 Oct 2024 13:41:14 -0400
> Subject: [PATCH] tests/test-subr.sh: Put test_dir under /var/tmp.
> 
> Every individual test in elfutils involves a temporary directory.
> Previous version of this script put that directory under the build
> tree.  That's OK if it's a local disk, but if it's on NFS, then some
> tests - run-large-elf-file.sh, several run-debuginfod-*.sh - take long
> enough to run to fail tests intermittently.
> 
> This patch moves the temp_dir under ${TMPDIR-/var/tmp/}, so it
> operates at local disk speed rather than whatever-build-filesystem
> speed.  Individual test scripts are all unaffected.  (One could
> consider /tmp instead, which is a RAM disk on modern systems, except
> that some of the elfutils tests produce GB-sized temporary files.
> That's probably too big for RAM.)

Looks good to me.

Thanks,

Mark