[PATCH] ar: Replace one alloca use by xmalloc
Mark Wielaard
mark@klomp.org
Sun May 12 21:55:37 GMT 2024
Hi Aaron,
On Fri, May 10, 2024 at 05:16:06PM -0400, Aaron Merey wrote:
> On Tue, Apr 30, 2024 at 10:39 AM Mark Wielaard <mark@klomp.org> wrote:
> >
> > This alloca use is inside a lexical block and is used to replace one
> > element of argv. Use a function local variable, xmalloc and free to
> > make memory usage pattern more clear.
> >
> > * src/ar.c (main): Move newp char pointer declaration up.
> > Use xmalloc to allocate space. free at end of main.
> >
> > Signed-off-by: Mark Wielaard <mark@klomp.org>
>
> LGTM. This patch shouldn't change anything except possibly help
> some static analyzers detect correct memory usage.
Thanks. Pushed as commit 3c71cab7c5bfba0549d0a1716e7061d07eafd794
Cheers,
Mark
More information about the Elfutils-devel
mailing list