[PATCH v2 3/4] libdw: Apply DWARF package file section offsets where appropriate

[Mark Wielaard]

Hi Omar,

On Thu, Feb 22, 2024 at 04:53:19PM -0800, Omar Sandoval wrote:
> On Fri, Feb 16, 2024 at 04:00:47PM +0100, Mark Wielaard wrote:
> > The code and tests look good. run-varlocs.sh seems good, which seems to
> > confirm DW_SECT_LOCLISTS is handled correctly (but why doesn't it need
> > a hack similar to ranges in __libdw_formptr?).
> 
> I think it's because ranges have the uniquely weird behavior in DWARF 4
> GNU Debug Fission that DW_AT_GNU_ranges_base is in the skeleton file but
> used to interpret the split file. This was cleaned up for DWARF 5 (as I
> documented in commit c9c9ffae725009b192b40e2d89035f353ae7055f), and
> there was no base attribute for location lists in DWARF 4, so it's not
> applicable.

Thanks. I forgot about commit c9c9ffae7 "libdw: Handle DW_AT_ranges in
split DWARF 5 skeleton in dwarf_ranges". That documents it nicely.

Cheers,

Mark