[PATCH 1/2] libdwfl: handle duplicate ELFs when reporting archives
Aleksei Vetrov
vvvvvv@google.com
Mon Nov 20 17:39:35 GMT 2023
Hello Mark,
On Sat, Nov 18, 2023 at 10:47 PM Mark Wielaard <mark@klomp.org> wrote:
> If we goto overlap here don't we still have a problem? overlap will
> set m->gc = true; and return NULL. So the caller will think they
> still owns the elf handle and will probably close it. But then when
> the module is GCed in dwfl_report_end it will close the elf handle
> again.
Thank you for noticing! Yes, this is oversight from my side.
> Should we instead move the elf_end and reassignment of main.elf to
> after this if statement?
Will fix exactly like this in [PATCH v2].
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://sourceware.org/pipermail/elfutils-devel/attachments/20231120/0fef7e0d/attachment.htm>
More information about the Elfutils-devel
mailing list