[PATCH] libelf/elf_newscn.c: fix build failure against gcc-14 (-Walloc-size)

Mark Wielaard mark@klomp.org
Thu Nov 2 23:23:59 GMT 2023


Hi Sergei,

On Thu, Nov 02, 2023 at 07:58:46PM +0000, Sergei Trofimovich wrote:
> `gcc-14` adde a new -Walloc-size warning that makes sure that size of an
> individual element matches size of a pointed type:
> 
>     https://gcc.gnu.org/PR71219
> 
> `elfutils` triggers is on `calloc()` call where member size is sued as
> `1`.
> 
>     elf_newscn.c: In function `elf_newscn`:
>     elf_newscn.c:97:12: error: allocation of insufficient size «1» for type «Elf_ScnList» with size «16» [-Werror=alloc-size]
>        97 |       newp = calloc (sizeof (Elf_ScnList)
>           |            ^
> 
> The change swaps arguments to pass larger value as a member size.

Very nice. Patch applied.

Thanks,

Mark


More information about the Elfutils-devel mailing list