[PATCH 2/5] backends: Add set_initial_registers_tid callback for LoongArch
Mark Wielaard
mark@klomp.org
Tue May 9 09:57:42 GMT 2023
Hi Youling,
On Tue, 2023-05-09 at 09:32 +0800, Youling Tang wrote:
> Thanks for pointing out that there is no need to mask the lower 32 bits
> here.
>
> It can be modified as follows,
> --- a/backends/loongarch_initreg.c
> +++ b/backends/loongarch_initreg.c
> @@ -79,11 +79,8 @@ loongarch_set_initial_registers_tid (pid_t tid
> __attribute__ ((unused)),
> if (ptrace (PTRACE_GETREGSET, tid, NT_FPREGSET, &iovec) != 0)
> return false;
>
> - Dwarf_Word dwarf_fregs[32];
> - for (int r = 0; r < 32; r++)
> - dwarf_fregs[r] = fregs.fpr[r] & 0xFFFFFFFF;
> -
> - if (! setfunc (32, 32, dwarf_fregs, arg))
> + /* $f0-$f31 */
> + if (! setfunc (32, 32, &fregs.fpr[0], arg))
>
> Do I need to send the v2 patchset again?
Please just sent this patch rebased against the current git branch. I
already pushed the other 4 patches since they looked good.
Thanks,
Mark
More information about the Elfutils-devel
mailing list