[PATCH] debuginfod: fix http_requests_total{type="debuginfo"} when dwz is used

Frank Ch. Eigler fche@redhat.com
Wed Aug 17 11:48:01 GMT 2022


Hi -

> When dwarf_extract_source_paths is called, it can call handle_buildid
> when a rpm file used dwz. Ignore such internal request in
> http_requests_total statistics.

Noble goal:

> @@ -1906,7 +1906,7 @@ handle_buildid (MHD_Connection* conn,
>                  const string& buildid /* unsafe */,
>                  string& artifacttype /* unsafe, cleanse on exception/return */,
>                  const string& suffix /* unsafe */,
> -                int *result_fd)
> +                int *result_fd, bool update_metrics = true)

.... but no need for an extra parameter.  When conn==0, we have
an internal request, so can use that as a flag.


- FChE



More information about the Elfutils-devel mailing list