[PATCH] debuginfod: Check result of calling MHD_add_response_header.

Mark Wielaard mark@klomp.org
Wed Dec 1 12:24:07 GMT 2021


H Frank,

On Wed, 2021-12-01 at 07:02 -0500, Frank Ch. Eigler wrote:
> Although unlikely the MHD_add_response_header can fail for
> > various reasons.  If it fails something odd is going on.
> > So check we can actually add a response header before using
> > the response.
> 
> ISTM it is okay to send the response object (the body), even if
> something goes wrong with adding optional headers later.

OK, so log error, but proceed sending the response with the data
already added. I'll update my patch to do that instead. I don't really
think this will really fail often (or at all). But if it does, it would
be good to be able to catch it.

Thanks,

Mark


More information about the Elfutils-devel mailing list