[PATCH] debuginfod: PR28242 - extend server http-response metrics

Mark Wielaard mark@klomp.org
Wed Oct 6 14:57:25 GMT 2021


On Fri, 2021-10-01 at 22:05 +0800, Di Chen via Elfutils-devel wrote:
> From a574dfaf5d5636cbb7159a0118eb30e2c4aaa301 Mon Sep 17 00:00:00
> 2001
> From: Di Chen <dichen@redhat.com>
> Date: Fri, 1 Oct 2021 22:03:41 +0800
> Subject: [PATCH] debuginfod: PR28242 - extend server http-response
> metrics

BTW. If possible use git send-email HEAD^ or attach the result of git
format-patch HEAD^ which will make sure some whitespace/linebreaks pass
through the mailinglist better.

> This patch aims to extend http_responses_* metrics with another label
> "type" by getting the extra artifact-type content added as a new
> key=value
> tag.
> https://sourceware.org/bugzilla/show_bug.cgi?id=28242

I believe the patch does what it says, the locking seems good and the
testcases have been adapted. Nice work. It is missing a ChangeLog entry
which would have helped a little with review.

But I would like someone else (Frank?) who knows more about the metrics
to take a quick peek before pushing.



More information about the Elfutils-devel mailing list