PATCH: testsuite debuginfod

Mark Wielaard
Tue Oct 5 16:55:34 GMT 2021

Hi Frank,

On Thu, 2021-09-30 at 10:50 -0400, Frank Ch. Eigler via Elfutils-devel
> commit 85602ff68179053f19a2005df4fc653a69757584 (HEAD -> master)
> Author: Frank Ch. Eigler <>
> Date:   Thu Sep 30 10:48:00 2021 -0400
>     debuginfod testsuite: Use ! CMD syntax.
>     Previously, we had a mishmash of iffy && || constructs to
>     reverse the rc of a subprocess that we expected to fail.
>     Now use
>        ! CMD
>     or
>        ! (CMD | CMD)
>     more systematically where possible.
>     Signed-off-by: Frank Ch. Eigler <>

Thanks, the && || conditionals do make my head hurt (I am not as
logical as I like). This looks much simpler.

I wish we can use this. But we use -e to make any failing command
(pipeline) fail the script/test. And man bash says (under -e Exit

   The shell does not exit if the command that fails is part of the
   command list immediately following a while or until keyword, part
   of the test following the if or elif reserved words, part of any
   command executed in a && or || list except the command following
   the final && or ||, any command in a pipeline but the last, or if
   the command's return value is being inverted with !.

So I am afraid any '! should_fail_but_does_not' will not actually exit
and so doesn't FAIL the test. Could you double check that?



More information about the Elfutils-devel mailing list