[Bug debuginfod/27982] added DEBUGINFOD_MAXSIZE and DEBUGINFOD_MAXTIME

Noah Sanci nsanci@redhat.com
Thu Jul 29 20:29:18 GMT 2021


> Why have MAXTIME default to LONG_MAX? Which is long, but different on
> different arches 32/64bit. If MAXSIZE == 0 means infinite, why not make
>  MAXTIME=0 the same for consistency?


> The bug suggests to also check the Content-Length header on reciept (in
> case the server didn't support or respect the X-DEBUGINFOD-MAXSIZE
> header. Did you try to implement that?


> I believe various error handling goto out1 should be goto out2 (after
> your duplicate urls patch). Could you double check that?


> diff --git a/tests/run-debuginfod-find.sh b/tests/run-debuginfod-find.sh
> index feec5ddf..8ed7743d 100755
> --- a/tests/run-debuginfod-find.sh
> +++ b/tests/run-debuginfod-find.sh
> @@ -187,7 +187,7 @@ tempfiles find-vlog$PORT1
>  # wait for the server to fail the same number of times the query is retried.
>  wait_ready $PORT1 'http_responses_after_you_milliseconds_count{code="406"}' 1
>  # quickly ensure all reporting is functional
> -grep 'serving file '${PWD}'/F/p+r%o\$g.debug' vlog$PORT1
> +grep 'serving file '$(realpath ${PWD})'/F/p+r%o\$g.debug' vlog$PORT1
>  grep 'File too large' vlog$PORT1
>  grep 'using max size 1B' find-vlog$PORT1
>  if [ -f ${DEBUGINFOD_CACHE_PATH}/${BUILDID} ]; then

Find all the fixes in the attached patch.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-debuginfod-PR27983-ignore-duplicate-urls.patch
Type: text/x-patch
Size: 9879 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/elfutils-devel/attachments/20210729/91cc1831/attachment-0001.bin>

More information about the Elfutils-devel mailing list