[PATCH] elfcompress: fix exit status in case of an error

Mark Wielaard mark@klomp.org
Wed May 12 20:29:33 GMT 2021


Hi Dmitry,

On Wed, May 12, 2021 at 04:00:00PM +0000, Dmitry V. Levin wrote:
> Exit status of 255 in case of an error is probably not what elfcompress
> users expect, change it to 1.
> 
> Reported-by: Vitaly Chikunov <vt@altlinux.org>
> Fixes: 92acb57eb046 ("elfcompress: New utility.")
> [...]  
> diff --git a/src/elfcompress.c b/src/elfcompress.c
> index 05f3bc2c..dacaff32 100644
> --- a/src/elfcompress.c
> +++ b/src/elfcompress.c
> @@ -1358,5 +1358,5 @@ main (int argc, char **argv)
>    while (++remaining < argc);
>  
>    free_patterns ();
> -  return result;
> +  return !!result;
>  }

The change to return 1 (or zero) is good.

But could we instead initialize res to 1 (or EXIT_FAILURE from
stdlib.h) at the top? That reads IMHO a little nicer than the !!
pattern.

Thanks,

Mark



More information about the Elfutils-devel mailing list