[PATCH 1/2] elfcompress: fix exit status in case of "Nothing to do"

Mark Wielaard mark@klomp.org
Wed May 12 20:04:50 GMT 2021


Hi Dmitry,

On Wed, May 12, 2021 at 10:18:36PM +0300, Dmitry V. Levin wrote:
> On Wed, May 12, 2021 at 03:00:00PM +0000, Dmitry V. Levin wrote:
> > When elfcompress decides that no section data needs to be updated and
> > therefore the file does not have to be rewritten, it still has to exit
> > with a zero status indicating success.
> > 
> > Resolves: https://sourceware.org/bugzilla/show_bug.cgi?id=27856
> > Fixes: ed62996defc6 ("elfcompress: Don't rewrite file if no section data needs to be updated.")
> 
> Correction: the faulty commit is elfutils-0.184~22, I'll update the
> "Fixes" tag in the commit message accordingly:
> 
> Fixes: c497478390de ("elfcompress: Replace cleanup() with label")

Thanks for tracking this regression down. Sorry I missed that in the
reviews. It is obvious in hindsight. The fix is correct.

Cheers,

Mark


More information about the Elfutils-devel mailing list