Remove misleading XOR
Timm Bäder
tbaeder@redhat.com
Thu Feb 25 10:41:05 GMT 2021
On 24/02/2021 14:16, Mark Wielaard wrote:>>> -#define NO_RESIZING 0u
>>> -#define ALLOCATING_MEMORY 1u
>>> -#define MOVING_DATA 3u
>>> -#define CLEANING 2u
>>> +#define NO_RESIZING 0x0
>>> +#define ALLOCATING_MEMORY 0x1
>>> +#define MOVING_DATA 0x3
>>> +#define CLEANING 0x2
>>
>> Nope, same result. :(
>
> Hmmm. I am not sure why that doesn't work. What if you make them
> explicitly unsinged (adding u at the end). Or does it simply ignore
> the values and just warn because it sees the macro name and not an
> explicit number?
I opened https://reviews.llvm.org/D97445 upstream and it looks like
the behavior with both LHS and RHS being a macro is just a bug. If that
patch gets accepted, it will fix the problems in the elfutils code base.
Would still be nice to have a work-around in the meantime I think.
- Timm
--
Red Hat GmbH, http://www.de.redhat.com/, Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Michael O'Neill, Tom Savage, Eric
Shander
More information about the Elfutils-devel
mailing list