[PATCH] tests: Quote make variables in TESTS_ENVIRONMENT

Mark Wielaard mark@klomp.org
Fri Feb 12 17:16:48 GMT 2021

Hi Alexander,

On Sun, 2021-02-07 at 16:48 +0100, Alexander Miller via Elfutils-devel
> Commit eb922a1b8f3a ("tests: use ${CC} instead of 'gcc' in tests")
> exports ${CC} into the test environment, but doesn't quote the
> value for the assignment. That doesn't work properly if the value
> contains whitespace. In a multilib/biarch environment however, it's
> common to set CC="gcc -m32" or similar. That causes tests to print
> error messages: "/bin/sh: line 2: -m32: command not found".
> Fix that by adding quotes around all make variables (not just $CC)
> used in setting up TESTS_ENVIRONMENT.

Thanks, that works except for the valgrind_cmd (used when configuring
with --enable-valgrind), because that was already quoted. I removed the
quotes in the original variable assignment and pushed the patch as


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-tests-Quote-make-variables-in-TESTS_ENVIRONMENT.patch
Type: text/x-patch
Size: 3667 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/elfutils-devel/attachments/20210212/dbada282/attachment-0001.bin>

More information about the Elfutils-devel mailing list