[PATCH 3/4] ar: Pull should_truncate_fname() into file scope

Timm Bäder tbaeder@redhat.com
Tue Feb 2 15:25:36 GMT 2021

On 29/01/2021 21:48, Mark Wielaard wrote:
> Hi Timm,
> On Fri, 2021-01-08 at 09:13 +0100, Timm Bäder via Elfutils-devel wrote:
>> Get rid of a nested function this way.
> Skipping this one for now since I don't believe I understand this code.
> Could you explain what the code does what it does and why it works fine
> when moved this way?

Right, I guess you mean because the old code used to assign a new value
to name_max, but the new code doesn't do that? I fixed that locally
now by taking a size_t* inout argument instead, so assigning to
name_max should have the desired effect again.

- Timm

Red Hat GmbH, http://www.de.redhat.com/, Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Michael O'Neill, Tom Savage, Eric 

More information about the Elfutils-devel mailing list