Pending nested function removal

Navin P navinp0304@gmail.com
Thu Jan 28 08:02:20 GMT 2021


On Thu, Jan 28, 2021, 13:16 Timm Bäder <tbaeder@redhat.com> wrote:

> On 28/01/2021 06:19, Navin P via Elfutils-devel wrote:
> > Hi,
> >     I tried to compile the nested functions and most of the files are
> > complete. I find few others still pending. Below is the list which
> > still has a nested function.
> > I'm attaching the logfile for line numbers and column no.
> >
> > grep "function definition is not allowed here" logfile
> > elf-from-memory.c:234:2: error: function definition is not allowed here
> > elf-from-memory.c:314:2: error: function definition is not allowed here
>
> elf-from-memory:
> https://sourceware.org/pipermail/elfutils-devel/2021q1/003373.html
>
> > readelf.c:391:3: error: function definition is not allowed here
> > readelf.c:3617:7: error: function definition is not allowed here
> > readelf.c:6222:3: error: function definition is not allowed here
> > readelf.c:8747:7: error: function definition is not allowed here
> > readelf.c:12119:3: error: function definition is not allowed here
>
> readelf:
> https://sourceware.org/pipermail/elfutils-devel/2021q1/003381.html
>
> > strip.c:524:4: error: function definition is not allowed here
> > strip.c:1540:8: error: function definition is not allowed here
> > strip.c:2131:2: error: function definition is not allowed here
> > strip.c:2159:6: error: function definition is not allowed here
>
> strip:
> https://sourceware.org/pipermail/elfutils-devel/2021q1/003368.html
>
>
> > elflint.c:3450:3: error: function definition is not allowed here
> > elflint.c:3463:3: error: function definition is not allowed here
> > addr2line.c:697:4: error: function definition is not allowed here
> > addr2line.c:704:4: error: function definition is not allowed here
> > arlib-argp.c:63:3: error: function definition is not allowed here
> > ar.c:449:3: error: function definition is not allowed here
>
> addr2line, arlib-argp, ar, zstrptr:
> https://sourceware.org/pipermail/elfutils-devel/2021q1/003376.html
>
> > unstrip.c:443:5: error: function definition is not allowed here
> > unstrip.c:1202:5: error: function definition is not allowed here
> > unstrip.c:1453:5: error: function definition is not allowed here
> > unstrip.c:2236:3: error: function definition is not allowed here
> > unstrip.c:2496:5: error: function definition is not allowed here
> > elfcompress.c:280:3: error: function definition is not allowed here
> > elfcompress.c:285:3: error: function definition is not allowed here
> > elfcompress.c:291:3: error: function definition is not allowed here
> > elfcompress.c:299:3: error: function definition is not allowed here
>
> I have the others locally but wanted feedback on the patches I posted
> first. Maybe I should re-post them with the changelog entries
> I forgot :)
>

Yes, please merge them.The already committed ones are good.

Please update when you are done

>


More information about the Elfutils-devel mailing list