[PATCH] Fix automake warnings

[Mark Wielaard]

On Thu, 2020-12-10 at 02:34 +0300, Dmitry V. Levin wrote:
> Apparently, commit 2f02e81510946a4c8e9157ad0b72d92894b9acd7 that
> removed
> $(EXEEXT) suffix from shared libraries was incomplete: it missed the
> fact that some libraries were included into noinst_PROGRAMS,
> resulting
> to the following automake warnings:
> 
> libasm/Makefile.am:66: warning: deprecated feature: target
> 'libasm.so' overrides 'libasm.so$(EXEEXT)'
> libdw/Makefile.am:114: warning: deprecated feature: target 'libdw.so'
> overrides 'libdw.so$(EXEEXT)'
> libelf/Makefile.am:116: warning: deprecated feature: target
> 'libelf.so' overrides 'libelf.so$(EXEEXT)'
> 
> Fix this by renaming noinst_PROGRAMS to noinst_DATA and removing no
> longer needed lib{asm,dw,elf}_so_SOURCES variables.

Very nice. I have one small issue, with automake 1.13.4 when removing
the lib{asm,dw,elf}_so_SOURCES variables no clean rule is generated
anymore for these files. So make clean leaves the .so behind. This is
easily fixed by adding them to CLEANFILES. Does the attached variant
work for you?

Thanks,

Mark
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-automake-warnings.patch
Type: text/x-patch
Size: 5545 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/elfutils-devel/attachments/20201210/b22f6979/attachment.bin>