link_map: Remove nested functions

Mark Wielaard mark@klomp.org
Sun Dec 6 13:41:54 GMT 2020


Hi Timm,

On Tue, 2020-12-01 at 09:38 +0100, Timm Bäder via Elfutils-devel wrote:
> the attached patches get rid of nested functions in
> libdwfl/link_map.c.
> 
> I wrote these a while back and just looked at them again and we could
> use the same read_state struct here as well. I just quickly checked,
> but it seems a bit more involved due to the
> integrated_memory_callback
> handling. I can look into that anyway if required.

I had some comments on the first patch, the third patch seems fine and
has been committed. If you have adjust for the changes in the first
patch it would be nice if you could look at making the second patch
read_addrs function take a bit less than 11 arguments,

Note that all patches were missing ChangeLog entries and Signed-off-by
lines.

Cheers,

Mark


More information about the Elfutils-devel mailing list