[PATCH 14/14] segment_report_module: Inline consider_phdr() into only caller

Timm Bäder tbaeder@redhat.com
Fri Nov 13 07:41:07 GMT 2020


On 12/11/2020 17:52, Navin P wrote:
> Hi,
>   I already have a patch that makes elfutils compile with clang. Since
> you are working
> this will be of use to you. I've attached the patch since it is big.
> 
>   Here are some of the changes
>   1. All functions at file scope have static qualifier so that no
> collison with other files.
>   2. Non global variables declared in the outer function should be
> passed as pointer variable
>      in the new outer file scope function whenever they are assigned in
> the nested  function. The
>      argument  addition in new functions are at the end.
> 
> 3.  With the applied patch above , gcc passes all 220 tests where
> clang fails 3 tests which
>     is due to llvm_addrsig (change in libelf/elf.h ) and other 2 tests
> are error related to
> .rela.eh_frame.

Thanks, Navin. Has this been proposed for inclusion in elfutils? What's
the status on that? Or are you just keeping this locally?

Looking at the patch, I'm not really a fan of a few of those changes,
from a code point of view. consider_phdr() takes 35 arguments now
for example.

Do you have more information on the test failures? Are they caused by
LLVM/clang bugs?



Thanks,
Timm



More information about the Elfutils-devel mailing list