[PATCH] Fix bug in read_3ubyte_unaligned_inc

Tom Tromey tom@tromey.com
Thu Oct 29 19:36:19 GMT 2020


>>>>> "Mark" == Mark Wielaard <mark@klomp.org> writes:

Mark> On Sat, Oct 24, 2020 at 03:05:55PM -0600, Tom Tromey wrote:
Mark> Clearly DW_FORM_strx3 and DW_FORM_addrx3 aren't used much
Mark> (given that it is an index value between larger than 65536).
>> 
>> I don't even really see the need for a 3-byte form.
>> Anyway if it helps, gdb gets this wrong too -- gdb always uses
>> little-endian, which seems wrong, but I didn't know how to write a
>> real-life test case.

Mark> How about the attached? It isn't very fancy, but it would have caught
Mark> the bug you found. And might be nice in case we ever refactor the
Mark> read_unaligned code.

Looks reasonable to me.  Thanks for doing that.

Tom


More information about the Elfutils-devel mailing list