[PATCH v3] unstrip: Stop using strndupa.

Mark Wielaard mark@klomp.org
Tue Oct 27 22:09:32 GMT 2020

Hi Érico,

On Tue, Oct 27, 2020 at 04:19:58PM -0300, Érico Nogueira via Elfutils-devel wrote:
> This functon has inherent safety issues, since a long enough path can
> lead to memory clobbering. Due to the recursive nature of
> make_directories(), multiple calls could also stack overflow. Instead,
> the string can be allocated in the heap.
> As a bonus, this improves musl compatibility, since musl doesn't include
> the strndupa macro for now.
> Also add braces around while loop.

Looks good. Pushed.
I did move and fixup the ChangeLog entry.
(each subdir has its own ChangeLog and they should tell what exactly change)



More information about the Elfutils-devel mailing list