[PATCH] Don't use locale functions when libintl header isn't included.
Mon Oct 26 22:44:43 GMT 2020
On Mon Oct 26, 2020 at 3:22 PM -03, Frank Ch. Eigler wrote:
> Hi -
> > On Mon, 2020-10-26 at 01:11 -0300, Ãrico Nogueira via Elfutils-devel wrote:
> > > debuginfod.cxx used the bindtextdomain() and textdomain() functions
> > > despite not including any translated output. These functions were also
> > > used without including the libintl.h header.
> > debuginfod doesn't directly use any translated output, but it links
> > against libeu.a which provides the print_version function, which does
> > use translated output. So maybe the correct fix is to #include
> > <libintl.h> instead?
> I think their concern may be that they don't have any libintl.h or
> related functions in the musl world.
> - FChE
No, musl does provide a libintl.h header and the necessary
implementations. My changes to debuginfod.cxx were only necessary
because the file was using functions from libintl.h even though the
header itself wasn't included. Following your comment on IRC, I will
make a new patch that just includes libintl.h.
More information about the Elfutils-devel