[PATCH] Fix bug in read_3ubyte_unaligned_inc

Mark Wielaard mark@klomp.org
Sat Oct 24 19:27:20 GMT 2020


On Fri, Oct 23, 2020 at 04:51:10PM -0600, Tom Tromey wrote:
> The read_3ubyte_unaligned_inc macro calls read_2ubyte_unaligned, but
> it should call read_3ubyte_unaligned.

Eep. And read_3ubyte_unaligned is actually is tricky to get right if
you want to correctly read 3-byte unsigned integers given the correct
endianness. But because we do add 3 to the address, it isn't an hard
error. Clearly DW_FORM_strx3 and DW_FORM_addrx3 aren't used much
(given that it is an index value between larger than 65536). I'll try
to add some testcase based on what you wrote for sleb128.

Pushed.

Thanks,

Mark


More information about the Elfutils-devel mailing list