[PATCH] debuginfo fdcache prefetching tweak

Mark Wielaard mark@klomp.org
Wed Oct 21 14:17:04 GMT 2020


Hi Frank,

On Wed, 2020-10-21 at 09:59 -0400, Frank Ch. Eigler wrote:
> So we still setup the whole archive, but then don't actually
> > iterate
> > through it. So shouldn't we check internal_req_p a little earlier and
> > just return from handle_buildid_r_match when it is set and we hit "no
> > match ... grumble, must process the archive"?
> 
> We do iterate through it, just don't *prefetch* (save) any archive
> files other than the requested one.

Ah, I misread the code. There is an || not an && in
  while(r == 0 || prefetch_count > 0)
and then we hit:
    if ((r == 0) && (fn != b_source1)) // stage 1
      continue;
in the loop.

So we don't save anything till we actually find it in the archive.
Got it.

The patch is perfect then.

Cheers,

Mark


More information about the Elfutils-devel mailing list