[PATCH] libdwfl: do not dlopen libdebuginfod.so in --disable-libdebuginfod mode
Sun Aug 30 20:40:29 GMT 2020
On Thu, Aug 20, 2020 at 11:27:24PM +0300, Dmitry V. Levin wrote:
> debuginfod-client.c used to try to dlopen libdebuginfod.so even if
> libdebuginfod was completely disabled using --disable-libdebuginfod.
> Fix this by disabling build of debuginfod-client.c and disabling all
> __libdwfl_debuginfod_* invocations in --disable-libdebuginfod mode.
To be honest I really hope libdebuginfod is only disabled for
bootstrapping reasons and that people will use
That said, your patch makes sense if people explicitly choose to
--disable-libdebuginfod and it handles --enable-libdebuginfod=dummy
To double check I removed all references to debuginfod_client from
libdwflP.h when libdebuginfod is disabled. And things look fine in
that case too. I think it makes sense to add this to your patch. See
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 1217 bytes
Desc: not available
More information about the Elfutils-devel