[PATCH] libdwfl: do not dlopen libdebuginfod.so in --disable-libdebuginfod mode

[Mark Wielaard]

Hi Dmitry,

On Thu, Aug 20, 2020 at 11:27:24PM +0300, Dmitry V. Levin wrote:
> debuginfod-client.c used to try to dlopen libdebuginfod.so even if
> libdebuginfod was completely disabled using --disable-libdebuginfod.
> 
> Fix this by disabling build of debuginfod-client.c and disabling all
> __libdwfl_debuginfod_* invocations in --disable-libdebuginfod mode.

To be honest I really hope libdebuginfod is only disabled for
bootstrapping reasons and that people will use
--enable-libdebuginfod=dummy.

That said, your patch makes sense if people explicitly choose to
--disable-libdebuginfod and it handles --enable-libdebuginfod=dummy
correctly.

To double check I removed all references to debuginfod_client from
libdwflP.h when libdebuginfod is disabled. And things look fine in
that case too. I think it makes sense to add this to your patch. See
attached.

Thanks,

Mark
-------------- next part --------------
A non-text attachment was scrubbed...
Name: nodebuginfod.patch
Type: text/x-diff
Size: 1217 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/elfutils-devel/attachments/20200830/54569a7f/attachment.bin>