[Bug backends/26176] Backend modules of elfutils are always linked to shared library

[fche at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26176

Frank Ch. Eigler <fche at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fche at redhat dot com

--- Comment #4 from maarten <madebr at gmail dot com> ---
Created attachment 12669
  --> https://sourceware.org/bugzilla/attachment.cgi?id=12669&action=edit
Add configure --enable-werror option (enabled by default)

--- Comment #5 from maarten <madebr at gmail dot com> ---
Created attachment 12670
  --> https://sourceware.org/bugzilla/attachment.cgi?id=12670&action=edit
add enable-static option to configure

--- Comment #6 from maarten <madebr at gmail dot com> ---

> I was actually going to propose we wouldn't build the static version by
> default because I didn't think anybody is actually using it.
> 
> What is your use case? And would it be a problem if we dropped building the
> static libraries by default, and you had to explicitly build the package
> with static libs?

conan has an option to build libraries statically or shared.
elfutils needed some patches to make this possible.

> > - disable -Werror
> 
> What errors/warnings are you seeing?

../source_subfolder/libdwfl/dwfl_build_id_find_elf.c: In function
‘__libdwfl_open_by_build_id’:
../source_subfolder/libdwfl/dwfl_build_id_find_elf.c:60:7: error: variable ‘n’
set but not used [-Werror=unused-but-set-variable]
   60 |   int n = snprintf (&id_name[sizeof "/.build-id/" - 1],
      |       ^
cc1: all warnings being treated as errors


> 
> > Also, it looks like `libasm.h` and `libdwfl.h` use types defined in
> > `gelf.h`, but do not include the header.
> 
> There was an issue in libasm.h which got fixed in elfutils-0.178-24-g287a1845
> libdwfl.h includes libdw.h which includes gelf.h so should be usable
> standalone.

`libasm.h` from 0.180 is only including system headers <stdbool.h> and
<stdint.h>.
You're correct about `libdwfl.h`, that one is including `gelf.h` through
`libdw.h`.


> Could you attach concrete patches to this bug report?

I've attached them.

Using `--disable-werror` + `--enable-static=yes/no` allows us to build elfutils
as static/shared libraries.

--- Comment #7 from Frank Ch. Eigler <fche at redhat dot com> ---
test

--- Comment #8 from Frank Ch. Eigler <fche at redhat dot com> ---
test2

-- 
You are receiving this mail because:
You are on the CC list for the bug.