[PATCH 06/10] ar, ranlib: Call fchown before fchmod, explicitly check and ignore errors.

Mark Wielaard mark@klomp.org
Fri Jun 19 18:52:51 GMT 2020


On Wed, 2020-06-17 at 00:25 +0200, Mark Wielaard wrote:
> In ar and ranlib we don't mind if the fchown call fails (it normally
> would, then the file simply gets own by the current user). We used to
> call fchown before fchmod, but that might ignore (or reset) some mode
> flags, so call fchown first, then try fchmod (like we already do in
> elfcompress). Also explicitly test and then ignore any errors for
> chown. We used to do some asm trick, but that confuses some static
> analyzers (and it is somewhat unreadable). Also split out the giant
> if statements to make them a little bit more understandable.

Pushed to master.


More information about the Elfutils-devel mailing list