[Bug general/24498] 0.176: isn't LTO ready

[mark at klomp dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=24498

--- Comment #15 from Mark Wielaard <mark at klomp dot org> ---
Thanks for that setup. It allows me to play a bit more with LTO.

One commit to help with one issue has been pushed already:

commit 39f28eaf8c821d71d57ffc759655ec4168d0bead
Author: Mark Wielaard <mark@klomp.org>
Date:   Thu Apr 16 17:45:31 2020 +0200

    libdwfl: Initialize bits to NULL in dwfl_standard_find_debuginfo for LTO.

    GCC10 LTO is too smart (and somewhat cryptic):

        find-debuginfo.c: In function ‘dwfl_standard_find_debuginfo’:
        debuginfod-client.c:85:8: error: ‘bits’ may be used uninitialized
        in this function [-Werror=maybe-uninitialized]
        find-debuginfo.c:360:24: note: ‘bits’ was declared here
        lto1: all warnings being treated as errors

    So it inlines __libdwfl_debuginfod_find_debuginfo into
    dwfl_standard_find_debuginfo and since it cannot see into the
    function pointer (*fp_debuginfod_find_debuginfo), it assumes that
    build_id_bit (== bits in dwfl_standard_find_debuginfo) will be used
    by the called function and it might not be initialized.
    But if you read the code the there is a check for build_id_len > 0
    to see whether bits is or isn't initialized before using bits.
    But gcc isn't smart enough to figure that out.

    Maybe that actually should be an heuristic gcc lto should use.
    If the callchain I am inlining is so deep that I cannot figure out
    maybe-uninitialized variables anymore I should stop inlining.

    For now just help GCC out and initialize bits to NULL.

    Signed-off-by: Mark Wielaard <mark@klomp.org>

I am not sure what to do about the various error: stack usage might be
unbounded [-Werror=stack-usage=] when "linking" the various tools.

If you look at the src/Makefile.am you'll see that for each file we make sure
to build with -Wno-stack-usage= But since lto1 combines both files that have
been compiled with and without that warning flag it reappears again.

The only workaround for now is using CFLAGS="... -Wno-error=stack-usage=" when
building inside the src/ directory. Which is a little ugly because it will
disable the error also when it should be checked...

-- 
You are receiving this mail because:
You are on the CC list for the bug.