patch PR25448: more debuginfod prometheus metrics

Mark Wielaard mark@klomp.org
Fri Mar 27 14:47:27 GMT 2020


Hi Frank,

On Thu, 2020-03-26 at 16:46 -0400, Frank Ch. Eigler via Elfutils-devel wrote:
> commit 34d851344dbaa5fd00b4368742839f86203202a1 (HEAD ->
> fche/pr25448)
> Author: Frank Ch. Eigler <fche@redhat.com>
> Date:   Thu Mar 26 16:44:20 2020 -0400
> 
>     PR25448: debuginfod: add transfer performance metrics
>     
>     We now export metrics related to the time taken and data sent,
>     from which prometheus type tools can compute nice time series
>     with averages.
>     
>     http_responses_duration_milliseconds_count{code="200"} 63
>     http_responses_duration_milliseconds_count{code="404"} 2
>     http_responses_duration_milliseconds_count{code="503"} 1
>     http_responses_duration_milliseconds_sum{code="200"} 66
>     http_responses_duration_milliseconds_sum{code="404"} 2
>     http_responses_duration_milliseconds_sum{code="503"} 0
>     http_responses_transfer_bytes_count{code="200"} 63
>     http_responses_transfer_bytes_count{code="404"} 2
>     http_responses_transfer_bytes_count{code="503"} 1
>     http_responses_transfer_bytes_sum{code="200"} 425177
>     http_responses_transfer_bytes_sum{code="404"} 18
>     http_responses_transfer_bytes_sum{code="503"} 37
>     
>     Signed-off-by: Frank Ch. Eigler <fche@redhat.com>
> 
> diff --git a/debuginfod/ChangeLog b/debuginfod/ChangeLog
> index 5e19db517472..ebb67b0df378 100644
> --- a/debuginfod/ChangeLog
> +++ b/debuginfod/ChangeLog
> @@ -1,3 +1,8 @@
> +2020-03-26  Frank Ch. Eigler <fche@redhat.com>
> +
> +	* debuginfod.cxx (handler_cb): Export two families of metrics for
> +	prometheus traffic analysis: response times and data amounts.

This looks nice. Do we have to document these anywhere, or are
prometheus metrics "self documenting"? I assume tools just take what
they can get from the json export and create graphs based on the name
count/sum patterns?

Thanks,

Mark


More information about the Elfutils-devel mailing list