patch PR25548: debuginfod canonicalized source paths
Frank Ch. Eigler
fche@redhat.com
Thu Mar 26 14:19:53 GMT 2020
Hi -
> > The following patch generalizes the webapi slightly, which allows
> > debuggers like lldb to operate against packages/binaries with
> > source files that include posix pathname noise.
> Could you add something that describes the exact form of
> canonicalization done? Maybe just:
>
> "Canonicalization is done according to RFC3986 section 5.2.4 (Remove
> Dot Segments), plus reducing any '//' to '/' in the path."
OK.
> > diff --git a/tests/debuginfod-rpms/fedora31/hello3-two-debuginfo-1.0-2.x86_64.rpm b/tests/debuginfod-rpms/fedora31/hello3-two-debuginfo-1.0-2.x86_64.rpm
> > new file mode 100644
> > index 000000000000..0cc24073aa3e
>
> When using git format-patch instead of git show you'll get something
> that people can apply and that shows how big the files are. I assume
> they are small? The existing ones are between the 4K and 12K.
Yes, they're the same size.
Thanks for the review!
- FChE
More information about the Elfutils-devel
mailing list