PR25267: debuginfod status logging improvements
Frank Ch. Eigler
fche@redhat.com
Thu Mar 26 14:05:43 GMT 2020
Hi -
> [...]
> > + obatched(clog) << conninfo(connection)
> > + << ' ' << method << ' ' << url
> > + << ' ' << http_code << ' ' << http_size
> > + << ' ' << (int)(deltas*1000) << "ms"
> > + << endl;
> > +
> > + return rc;
> > }
>
> Should the case where http_size == -1 be handled specially?
> Would it make sense to only log this if (verbose > 1) ?
Web server logs routinely include failures; it should be okay.
Thanks for the review!
- FChE
More information about the Elfutils-devel
mailing list