patch 1/2 debuginfod client

Mark Wielaard mark@klomp.org
Sat Nov 16 00:52:00 GMT 2019


On Thu, 2019-11-14 at 06:24 -0500, Frank Ch. Eigler wrote:
> > [...libdw* debuginfod_find_* calls]
> > But given that they are almost similar, I would suggest to move both
> > into their own file sharing most of the code to do the dlopen dance.
> 
> Where?  It can't be in the solib.  We're talking about sharing, what,
> two copies of three or four lines of code (the two dlopen attempts?),
> and a replacement function will not be shorter, all-in.

I was just thinking put them together in one file.
Otherwise, just add a comment in both that there is similar code in the
other file and if you update one, then you probably want to update the
other too.

Cheers,

Mark



More information about the Elfutils-devel mailing list