patch 1/2 debuginfod client

Mark Wielaard mark@klomp.org
Fri Nov 15 21:33:00 GMT 2019


On Tue, 2019-11-12 at 10:14 -0500, Frank Ch. Eigler wrote:
> > My only concern is that these might slow down configure when debuginfod
> > isn't enabled? Can/Should they be moved later after the enable test?
> 
> It'd be fractions of a second per configure run ... worth worrying about?

Probably not. One day we might clean up the configure.ac to make it a
bit more modern and faster.

> > > +PKG_PROG_PKG_CONFIG
> > > +AC_ARG_ENABLE([debuginfod], AC_HELP_STRING([--enable-debuginfod], [Build debuginfo server and client solib]))
> > > +AS_IF([test "x$enable_debuginfod" = "xyes"], [
> > > +    AC_DEFINE([ENABLE_DEBUGINFOD],[1],[Build debuginfo-server])
> > > +    PKG_CHECK_MODULES([libmicrohttpd],[libmicrohttpd >= 0.9.33])
> > > +    PKG_CHECK_MODULES([libcurl],[libcurl >= 7.29.0])
> > > +    PKG_CHECK_MODULES([sqlite3],[sqlite3 >= 3.7.17])
> > > +    PKG_CHECK_MODULES([libarchive],[libarchive >= 3.1.2])
> > > +], [enable_debuginfod="no"])
> > > +AM_CONDITIONAL([DEBUGINFOD],[test "x$enable_debuginfod" = "xyes"])
> > 
> > Would it be better to enable by default with an error to disable if any
> > dependencies (and CXX compiler?) aren't found?
> 
> That's up to you as a policy question.  We could keep it this way
> (manually opt in) for this release to minimize build complications for
> our non-rpm/intimate distro partners and then switch to opt-out the
> later.

If it is up to me, then I would like to enable by default and make it
stick, so that it is a conscious choice to disable it. How about:

diff --git a/configure.ac b/configure.ac
index 8495f4a2..f0d26f36 100644
--- a/configure.ac
+++ b/configure.ac
@@ -658,6 +658,9 @@ AS_IF([test "x$enable_debuginfod" != "xno"], [
     PKG_CHECK_MODULES([libcurl],[libcurl >= 7.29.0],[],[enable_debuginfod=no])
     PKG_CHECK_MODULES([sqlite3],[sqlite3 >= 3.7.17],[],[enable_debuginfod=no])
     PKG_CHECK_MODULES([libarchive],[libarchive >= 3.1.2],[],[enable_debuginfod=no])
+    if test "x$enable_debuginfod" = "xno"; then
+      AC_MSG_ERROR([C++ compiler or dependencies not found, use --disable-debuginfod to disable.])
+    fi
 ])
 
 AS_IF([test "x$enable_debuginfod" != "xno"],AC_DEFINE([ENABLE_DEBUGINFOD],[1],[Build debuginfod]))

I can push that on top of the debuginfod-submit branch, unless that
interferes with your work. I guess you want to squash and rebase it
again?

Thanks,

Mark



More information about the Elfutils-devel mailing list