patch 1/2 debuginfod client

Frank Ch. Eigler fche@redhat.com
Tue Nov 12 15:14:00 GMT 2019


Hi -

> A few comments on the first (top-level) part, just to make progress.

Thanks.


> > diff --git a/config/libdebuginfod.pc.in b/config/libdebuginfod.pc.in
> No Requires on libelf or libdw?

Correct, the debuginfo client code does not call into elfutils.


> My only concern is that these might slow down configure when debuginfod
> isn't enabled? Can/Should they be moved later after the enable test?

It'd be fractions of a second per configure run ... worth worrying about?


> > +PKG_PROG_PKG_CONFIG
> > +AC_ARG_ENABLE([debuginfod], AC_HELP_STRING([--enable-debuginfod], [Build debuginfo server and client solib]))
> > +AS_IF([test "x$enable_debuginfod" = "xyes"], [
> > +    AC_DEFINE([ENABLE_DEBUGINFOD],[1],[Build debuginfo-server])
> > +    PKG_CHECK_MODULES([libmicrohttpd],[libmicrohttpd >= 0.9.33])
> > +    PKG_CHECK_MODULES([libcurl],[libcurl >= 7.29.0])
> > +    PKG_CHECK_MODULES([sqlite3],[sqlite3 >= 3.7.17])
> > +    PKG_CHECK_MODULES([libarchive],[libarchive >= 3.1.2])
> > +], [enable_debuginfod="no"])
> > +AM_CONDITIONAL([DEBUGINFOD],[test "x$enable_debuginfod" = "xyes"])
> 
> Would it be better to enable by default with an error to disable if any
> dependencies (and CXX compiler?) aren't found?

That's up to you as a policy question.  We could keep it this way
(manually opt in) for this release to minimize build complications for
our non-rpm/intimate distro partners and then switch to opt-out the
later.


> >    OTHER FEATURES
> >      Deterministic archives by default  : ${default_ar_deterministic}
> >      Native language support            : ${USE_NLS}
> > +    Debuginfo server support           : ${enable_debuginfod}
> 
> client and server support?

Sure, changed.


- FChE



More information about the Elfutils-devel mailing list