[PATCH] lib + libdw: Add and use a concurrent version of the dynamic-size hash table.

Mark Wielaard mark@klomp.org
Thu Nov 7 11:07:00 GMT 2019


Hi,

On Mon, 2019-11-04 at 10:39 -0600, Jonathon Anderson wrote:
> Apologies, I talked with Srdan in person and forgot to relay the
> message. He gave me an updated version of the hash table that handles
> that issue (and another previously harmless typo).

This looks good. I am about to commit this, but would like to confirm
that the fixes in this change are as intended.

Looking at the difference between the previous version and this one, it
incorporates my simplification of FIND and lookup functions. And fixes
it by making insert_helper consistently return -1 when the value was
already inserted (hash == hval). And it fixes an issue where we were
using the the table entry val_ptr instead of the hashval as hash (was
that the typo? it didn't look harmless).

Sorry for being pedantic about this. But it is really tricky code, so I
want to be 100% sure all the above changes were intended.

Thanks,

Mark



More information about the Elfutils-devel mailing list