RISC-V disassembler

Mark Wielaard mark@klomp.org
Sat Sep 7 20:17:00 GMT 2019


Hi Ulrich,

On Sat, Sep 07, 2019 at 11:18:42AM +0200, Ulrich Drepper wrote:
> I'll check in the attached patch which implements a disassembler for
> RISC-V.  It also fixes a problem in the x86 disassember, exposed through
> the additions needed for RISC-V.

This is awesome. Thanks.

> Since aside rth, who added the BPF disassembler, no one beside me ever
> worked on that code I will push the changes as soon as I can.

You are right that nobody else will probably be able to properly
review these changes. And please feel free to commit changes that
don't see comments where you are the expert. But there is some value
in waiting a little bit after posting a patch. Someone might see some
issue, like the missing EXTRA_DIST files or simple whitespace issues,
that are nice to know, so commits don't break the build on other
systems.

If possible please do split the commits in independent parts. In this
case the x86 disassembler fix and po file updates could have been done
separately.

Normally we have ChangeLog entries for changes. If at all possible,
please add them. They really do help with reviewing and making sure
that what is committed/pushed was what was intended.

Please do add a Signed-off-by to your commits in the future.
See the CONTRIBUTING file for more details.

Thanks,

Mark



More information about the Elfutils-devel mailing list