[PATCH] elfclassify tool

Mark Wielaard mark@klomp.org
Mon Aug 12 15:18:00 GMT 2019


On Mon, Aug 12, 2019 at 10:14:20AM +0200, Florian Weimer wrote:
> * Mark Wielaard:
> 
> > What do you think about this change to dwelf_elf_begin?
> > The change would make it possible to detect real errors in the
> > elfclassify code, whether elf_begin or dwelf_elf_begin was used. So we
> > would not misclassify files (but return an error status of 2).
> 
> I'm not really familiar with how these functions are used, sorry,

I think you are selling yourself short. You did spot the issue with
using them. And that using them as "advertised" could cause
problems. Thanks for that.

> Viewed in isolation, the changes appear reasonable to me.

Thanks. That certainly is helpful feedback.

Unless there are objections or questions from other I intend to
check this into master tomorrow.

Cheers,

Mark



More information about the Elfutils-devel mailing list