[PATCH] elfclassify tool

Mark Wielaard mark@klomp.org
Mon Jul 29 14:40:00 GMT 2019


On Mon, Jul 29, 2019 at 11:22:13AM +0200, Florian Weimer wrote:
> * Mark Wielaard:
> 
> > Signed-off-by: Mark Wielaard <mark@klomp.org>
> 
> Does elfutils use DCO?  Then yoy have my signoff as well:
> 
> Signed-off-by: Florian Weimer <fweimer@redhat.com>

Thanks. Yes, elfutils uses a Developer Certificate of Origin based on
the linux kernel one (but clarified for the elfutils project details -
like some files having multiple licenses at the same time). We do
require all commits to have a Signed-off-by line from developers that
agree with the DCO as explained in the CONTRIBUTING document.

> You should you list yourself as an author somewhere in the commit
> message.

The ChangeLog entries do mention both of us as authors.

> Regarding the test case, I think if the build target is ELF, it makes
> sense to check that the elfutils binaries themselves are classified as
> expected, with the current build flags.  This will detect changes
> required due to the evolution of the toolchain.

That is what the run-elfclassify-self.sh testcase does I believe.
Or do you believe it should be extended?

Thanks,

Mark



More information about the Elfutils-devel mailing list