[PATCH elfutils 2/2] [tests] parse inode in /proc/pid/maps correctly in run-backtrace-data.sh

Mark Wielaard mark@klomp.org
Thu Jan 31 22:26:00 GMT 2019


On Thu, Jan 31, 2019 at 10:14:32PM +0100, Mark Wielaard wrote:
> So your fix is correct.
> But the testcase is also slightly wrong.
> It really shouldn't check errno if the function didn't fail.
> There is no guarantee that it will be zero.

So, even though it found a bug, I am removing these asserts.
They really aren't correct. When a function fails, it will
set errno. But if a function succeeds, there is no guarantee
that it will set errno to zero.

Attached patch pushed to master.

Cheers,

Mark
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-tests-Remove-assert-errno-0-from-tests.patch
Type: text/x-diff
Size: 5640 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/elfutils-devel/attachments/20190131/4bbe4b30/attachment.bin>


More information about the Elfutils-devel mailing list