[PATCH elfutils 2/2] [tests] parse inode in /proc/pid/maps correctly in run-backtrace-data.sh
Yonghong Song
yhs@fb.com
Fri Jan 25 21:20:00 GMT 2019
The backtrace-data.c parsed the inode in /proc/pid/maps with
format "%*x".
This caused failure if inode is big. For example,
7f269223d000-7f269226b000 r-xp 00000000 00:50 10224326387095067468 /home/...
The correct format should be "%*lu" to reflect inode "unsigned long" type.
But that caused the following compilation error.
acktrace-data.c: In function ‘maps_lookup’:
backtrace-data.c:109:22: error: use of assignment suppression and length modifier
together in gnu_scanf format [-Werror=format=]
i = fscanf (f, "%lx-%lx %*s %lx %*x:%*x %*lu", &start, &end, &offset);
Fix the test with inode format string "%*s" then.
Signed-off-by: Yonghong Song <yhs@fb.com>
---
tests/backtrace-data.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/backtrace-data.c b/tests/backtrace-data.c
index 3a91c664..85ae9729 100644
--- a/tests/backtrace-data.c
+++ b/tests/backtrace-data.c
@@ -106,7 +106,7 @@ maps_lookup (pid_t pid, Dwarf_Addr addr, GElf_Addr *basep)
{
// 37e3c22000-37e3c23000 rw-p 00022000 00:11 49532 /lib64/ld-2.14.90.so */
unsigned long start, end, offset;
- i = fscanf (f, "%lx-%lx %*s %lx %*x:%*x %*x", &start, &end, &offset);
+ i = fscanf (f, "%lx-%lx %*s %lx %*x:%*x %*s", &start, &end, &offset);
assert (errno == 0);
if (i != 3)
break;
--
2.17.1
More information about the Elfutils-devel
mailing list