[PATCH] configure: Add new --enable-install-elfh option.

Mark Wielaard mark@klomp.org
Thu Jan 24 17:53:00 GMT 2019


On Fri, 2019-01-18 at 14:03 +0000, Ulf Hermann wrote:
> I think you should also adapt tests/Makefile.am to use our own elf.h
> in 
> this case. See https://codereview.qt-project.org/#/c/187812/25 for
> my 
> solution to this.

Yes, it should indeed.
I used a slightly different solution though.
It relies on the default include flags already including the srcdirs.
Does that work for your use case too? (See revised patch attached.)

I looked at the features.h tweak also in your patch.
But I am not comfortable including something like that.
It feels like it needs a different test (whether we are actually on a
POSIX system or not). And I am not sure it really should define uid_t,
gid_t, mode_t, and pid_t. Those normally don't come from features.h
(they would come from sys/types.h).

Cheers,

Mark
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-configure-Add-new-enable-install-elfh-option.patch
Type: text/x-patch
Size: 4932 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/elfutils-devel/attachments/20190124/bcacd7c0/attachment.bin>


More information about the Elfutils-devel mailing list