ChangeLog entries (Was: [PATCH v3] Use fallthrough attribute)

Mark Wielaard
Sat Feb 10 12:39:00 GMT 2018

On Fri, 2018-02-09 at 22:36 -0500, Frank Ch. Eigler wrote:
> On Sat, Feb 10, 2018 at 03:26:43AM +0100, Mark Wielaard wrote:
> > I added ChangeLog entries and pushed it to master.
> What's a ChangeLog entry?  :-)

Yeah, yeah, I know. I am the last one to care.
Really, it helps me review code (even my own - actually writing them
makes me happy - o, right I did that!). If only to know a change is
really intended to be there.

To me the problem with dropping them is that there is no description
anymore what changed. The commit message normally describes why
something changed, not how. You of course have the diff to see what
changed, but not in a summary form. And I really like to have a summary
to cross check that what changed was intended to change.

For people that don't like them, what exactly is it about them that you
don't like? And what would you suggest as replacement?



More information about the Elfutils-devel mailing list