[PATCH] config: Add pkgincludedir to Cflags

Namhyung Kim namhyung@gmail.com
Tue Dec 12 14:51:00 GMT 2017


Hello,

On Tue, Dec 12, 2017 at 8:13 AM, Mark Wielaard <mark@klomp.org> wrote:
> On Fri, 2017-12-08 at 15:17 +0900, Namhyung Kim wrote:
>> The libelf and libdw uses pkginclude_HEADERS but the pkg-config file
>> misses to have it the Cflags.  This was a problem for libdw users since
>> it gave nothing to include, but one needs to add /usr/include/elfutils
>> directory to use the libdw.h header file.
>
> I this really an issue?
>
> libelf has two public headers which are placed in the includedir and so
> should be simply included as #include <libelf.h> and #include <gelf.h>.
>
> libdw does indeed put its headers in includdir/elfutils, but as far as
> I know everybody includes them using that subdir, so #include
> <elfutils/libdw.h> and #include <elfutils/libdwfl.h>, etc.
>
> Wouldn't this change how people include the headers?
> Do we want to change it?

Oh, I wasn't aware of the (preferred) way of including libdw headers.
Will change my code to use that pattern.  Sorry for the noise.

Thanks,
Namhyung



More information about the Elfutils-devel mailing list