[COMMITTED] backends: Swap sys/ptrace.h and asm/ptrace.h include order on s390.

[Dmitry V. Levin]

On Mon, Jul 17, 2017 at 06:41:47PM +0200, Mark Wielaard wrote:
> On Mon, 2017-07-17 at 19:29 +0300, Dmitry V. Levin wrote:
> > On Mon, Jul 17, 2017 at 05:44:54PM +0200, Mark Wielaard wrote:
> > > glibc 2.26 changed the sys/ptrace.h header so that it cannot be included
> > > after asm/ptrace.h. We still need to include the kernel asm/ptrace.h for
> > > the ptrace_area definition. Including it after sys/ptrace.h works against
> > > both old and new glibc.
> > 
> > If it's a glibc regression, shouldn't it be fixed on glibc side before
> > 2.26 is out?
> 
> I asked and it was done deliberately. See glibc 2.26 NEWS under
> Deprecated and removed features, and other changes affecting
> compatibility.

There are exactly two commits in glibc since 2.25 that changed
sysdeps/unix/sysv/linux/s390/sys/ptrace.h:
3f67d1a7021ed3184830511636a0867faec730fe and
b08a6a0dea63742313ed3d9577c1e2d83436b196.

I reviewed and approved both of these commits assuming that they brought
no regressions.  If sys/ptrace.h from glibc 2.25 could be included before
or after linux/ptrace.h, this shouldn't have changed in glibc 2.26.

In other words, I think you've spotted a regression that I missed during
b08a6a0dea63742313ed3d9577c1e2d83436b196 review and that has to be fixed
in glibc before 2.26 is released.


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/elfutils-devel/attachments/20170717/ab4e85f3/attachment.sig>